bruno
224bda74d5
- Conversion `async def` → `def` de TOUTES les routes dont le corps ne contient ni `await`, ni `async with`, ni `async for`, ni `asyncio` (scan automatique corps par corps sur app/ : 352 converties, 0 dangereuses, vérifié `asyncio`/`run_coroutine`/`.result()` absents). FastAPI exécute ces handlers dans son threadpool → tout leur SQLite (`get_conn()` + `conn.execute`) quitte l'event loop, sans changer une ligne de logique. - Répartition : api_v2 60, dashboard 40, collections 25, board 23, workspace 19, wiki 17, permissions 14, api 14, main.py 6, + 35 fichiers. - Les 4 routers prioritaires de l'audit sont couverts par ce lot : api_v2 60 + dashboard 40 + collections 25 + board 23 = 148 conversions (le reste de leurs routes attend la phase 2 : elles ont de vrais `await`). - Reste (phase 2) : les 311 routes avec de vrais `await` → enrouler les blocs DB dans `await anyio.to_thread.run_sync(...)` ; pas de wrapper partagé livré (rien ne l'appellerait — YAGNI jusqu'au premier usage). suite **1037/1037** (233 s) · `ruff check app tests` OK · docs à jour
99 lines
4.1 KiB
Python
99 lines
4.1 KiB
Python
"""FlowDeck — agent governance API (v7.2.0): policies + approval queue."""
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
|
|
from fastapi import APIRouter, HTTPException, Request
|
|
from fastapi.responses import JSONResponse
|
|
|
|
from app.auth.session import SessionManager
|
|
from app.db import get_conn
|
|
from app.services import agent_policies as policies
|
|
from app.services.api_v2_helpers import audit_log
|
|
|
|
router = APIRouter(tags=["governance"])
|
|
|
|
|
|
def _owner_or_admin(request: Request) -> dict:
|
|
user = SessionManager.decode_session(request.cookies.get("flowdeck_session", ""))
|
|
if not user or not user.get("id"):
|
|
raise HTTPException(401, "Authentication required")
|
|
with get_conn() as conn:
|
|
row = conn.execute("SELECT is_admin FROM users WHERE id=?", (user["id"],)).fetchone()
|
|
is_admin = bool(row and row["is_admin"])
|
|
if not is_admin and request.query_params.get("workspace_id"):
|
|
member = conn.execute(
|
|
"SELECT role FROM workspace_members WHERE workspace_id=? AND user_id=?",
|
|
(request.query_params.get("workspace_id"), user["id"])).fetchone()
|
|
owner = conn.execute("SELECT id FROM workspaces WHERE id=? AND owner_id=?",
|
|
(request.query_params.get("workspace_id"),
|
|
user["id"])).fetchone()
|
|
if not member and not owner:
|
|
raise HTTPException(403, "Workspace access required")
|
|
if member and member["role"] not in ("admin", "editor", "owner"):
|
|
raise HTTPException(403, "Editor role required")
|
|
user["is_admin"] = is_admin
|
|
return user
|
|
|
|
|
|
@router.get("/api/v2/agent-policies")
|
|
def list_policies(request: Request):
|
|
_owner_or_admin(request)
|
|
with get_conn() as conn:
|
|
rows = conn.execute("SELECT * FROM agent_policies ORDER BY workspace_id").fetchall()
|
|
return {"policies": [dict(r) for r in rows]}
|
|
|
|
|
|
@router.post("/api/v2/agent-policies")
|
|
async def upsert_policy(request: Request):
|
|
user = _owner_or_admin(request)
|
|
try:
|
|
body = await request.json()
|
|
except Exception:
|
|
body = {}
|
|
wid = body.get("workspace_id")
|
|
tools = body.get("allowed_tools")
|
|
if tools is not None and not isinstance(tools, list):
|
|
raise HTTPException(400, "allowed_tools must be a list or null")
|
|
with get_conn() as conn:
|
|
conn.execute(
|
|
"""INSERT INTO agent_policies (workspace_id, allowed_tools_json, max_steps,
|
|
require_approval)
|
|
VALUES (?,?,?,?)
|
|
ON CONFLICT(workspace_id) DO UPDATE SET
|
|
allowed_tools_json=excluded.allowed_tools_json,
|
|
max_steps=excluded.max_steps, require_approval=excluded.require_approval""",
|
|
(wid, json.dumps(tools) if tools is not None else None,
|
|
max(1, min(int(body.get("max_steps") or 12), 50)),
|
|
1 if body.get("require_approval") else 0))
|
|
conn.commit()
|
|
row = conn.execute("SELECT * FROM agent_policies WHERE workspace_id IS ?",
|
|
(wid,)).fetchone()
|
|
audit_log(user, "agent.policy.upsert", "workspace", wid or 0, "", request)
|
|
return JSONResponse(status_code=201, content=dict(row))
|
|
|
|
|
|
@router.get("/api/v2/agent-approvals")
|
|
def list_approvals(request: Request):
|
|
_owner_or_admin(request)
|
|
status = request.query_params.get("status", "pending")
|
|
with get_conn() as conn:
|
|
rows = conn.execute("SELECT * FROM agent_approvals WHERE status=? ORDER BY id DESC"
|
|
" LIMIT 100", (status,)).fetchall()
|
|
return {"approvals": [dict(r) for r in rows]}
|
|
|
|
|
|
@router.post("/api/v2/agent-approvals/{approval_id}/decide")
|
|
async def decide_approval(approval_id: int, request: Request):
|
|
user = _owner_or_admin(request)
|
|
try:
|
|
body = await request.json()
|
|
except Exception:
|
|
body = {}
|
|
out = policies.decide_approval(approval_id, user["id"], bool(body.get("approve")))
|
|
if out is None:
|
|
raise HTTPException(404, "Pending approval not found")
|
|
audit_log(user, "agent.approval.decide", "agent_approval", approval_id,
|
|
out["status"], request)
|
|
return out
|