test: A32 TERMINÉ — 6 routes Gitea stubbées + bug prod fd_icon (v7.20.0)
Les 6 dernières routes d'A32 (api.py, gitea) avec stub de transport — zéro
réseau réel :
- _stub_gitea() : stubs manuels sur gitea_client.gitea (create_issue,
update_issue, update_issue_labels, get_issue, get_issue_comments) avec
ÉTAT MUTABLE PARTAGÉ — le handler PATCH re-fetch l'issue via get_issue,
un canevas figé aurait masqué la mise à jour.
- POST /issues : carte INSÉRÉE sur le board (board seedé par endpoint) ;
PATCH : colonne recalculée sans perdre la carte.
- GET /issues JSON + HTML : ?format=html requis (le segment /html ne fixe pas
le paramètre, le handler le lit dans la query) ; stub qui lève → 404.
- POST /checklists + POST /checklist-items : lignes vérifiées en base,
404 sans board ; cleanup (items → checklists).
BUG PROD corrigé (trouvé par le smoke HTML) : card_detail.html utilisait la
macro fd_icon SANS l'importer → UndefinedError → 500 systématique sur
GET /api/issues/...?format=html (seul rendu du template dans le code).
Fix : {% from '_icons.html' import fd_icon %}.
A32 COMPLET : plus aucun router « 0 test » (webhooks, notes, sidebar_config,
github_routes, library, api, dashboard, api_v2 tous couverts).
test_smoke_uncovered.py : 52 tests. suite **1089/1089** · ruff OK · docs à jour
This commit is contained in:
@@ -1,5 +1,30 @@
|
||||
# Changelog - FlowDeck
|
||||
|
||||
## v7.20.0 (2026-10-01) — Audit : A32 TERMINÉ (routes Gitea + bug fd_icon)
|
||||
|
||||
### Fixed
|
||||
|
||||
- **Bug prod trouvé par les smokes** : `card_detail.html` appelait la macro
|
||||
`fd_icon` **sans l'importer** → `UndefinedError` → **500 systématique** sur
|
||||
`GET /api/issues/{o}/{r}/{id}?format=html` (seul rendu du template dans le
|
||||
code) → `{% from '_icons.html' import fd_icon %}` ajouté
|
||||
|
||||
### Tests
|
||||
|
||||
- Les **6 dernières routes d'A32** (Gitea, stub de transport, zéro réseau) :
|
||||
· stubs manuels sur `gitea_client.gitea` avec **état mutable partagé**
|
||||
(le handler PATCH re-fetch l'issue via `get_issue` — un canevas figé
|
||||
aurait masqué la mise à jour)
|
||||
· `POST /issues` : carte **insérée sur le board** ; `PATCH` : colonne
|
||||
recalculée **sans perdre la carte**
|
||||
· `GET /issues` JSON + **HTML** (`?format=html` — le segment `/html` ne fixe
|
||||
pas le paramètre `format`, il est lu dans la query) ; stub qui lève → 404
|
||||
· `POST /checklists` + `POST /checklist-items` : lignes **vérifiées en
|
||||
base**, 404 sans board
|
||||
- `test_smoke_uncovered.py` : **52 tests** ; suite complète **1089/1089**
|
||||
- **A32 complet** : plus aucun router « 0 test » (webhooks, notes,
|
||||
sidebar_config, github_routes, library, api, dashboard, api_v2)
|
||||
|
||||
## v7.19.0 (2026-10-01) — Audit : A32 : dashboard bloqué (44/44)
|
||||
|
||||
### Tests
|
||||
|
||||
+2
-2
File diff suppressed because one or more lines are too long
+1
-1
@@ -1,6 +1,6 @@
|
||||
# WORKLOAD — FlowDeck Notion Clone
|
||||
|
||||
> **Début**: 2026-07-08 | **Version**: v7.19.0 (audit — A32 : dashboard 44/44 routes à 0 ref couvertes) | **Statut**: EN COURS 🔄
|
||||
> **Début**: 2026-07-08 | **Version**: v7.20.0 (audit — A32 TERMINÉ : routes Gitea stubbées + bug fd_icon) | **Statut**: EN COURS 🔄
|
||||
> **Cible**: parité Notion + intégration forge · **Follow-ups v7.3 livrés**: sidebar teamspaces, notif `page.updated`, charts `number` + dashboards multi-DB, unfurl forge, UI Settings → Audit — voir `ROADMAP.md § v7.3.0`
|
||||
|
||||
## Avancement Global
|
||||
|
||||
+1
-1
@@ -185,7 +185,7 @@ async def lifespan(_app: FastAPI):
|
||||
|
||||
app = FastAPI(
|
||||
title="FlowDeck",
|
||||
version="7.19.0",
|
||||
version="7.20.0",
|
||||
docs_url="/docs",
|
||||
redoc_url="/redoc",
|
||||
lifespan=lifespan,
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
{# Card detail modal content — full issue info + comments #}
|
||||
{% from '_icons.html' import fd_icon %}
|
||||
<div class="card-detail" x-data="cardDetail()">
|
||||
<!-- Title -->
|
||||
<div style="display:flex; align-items:flex-start; gap:12px; margin-bottom:16px;">
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
"openapi": "3.1.0",
|
||||
"info": {
|
||||
"title": "FlowDeck",
|
||||
"version": "7.19.0"
|
||||
"version": "7.20.0"
|
||||
},
|
||||
"paths": {
|
||||
"/auth/register": {
|
||||
|
||||
@@ -728,6 +728,160 @@ def test_dashboard_convert_to_database(client):
|
||||
conn.commit()
|
||||
|
||||
|
||||
# ── api.py : les 6 routes Gitea (stub de transport — zéro réseau) ────────────
|
||||
|
||||
_CANNED_ISSUE = {
|
||||
"number": 42, "title": "Issue A32", "body": "description a32",
|
||||
"state": "open", "labels": [], "assignee": None, "due_date": "",
|
||||
"created_at": "2026-10-01T00:00:00Z", "user": {"login": "giteux"},
|
||||
}
|
||||
|
||||
|
||||
def _stub_gitea(monkeypatch):
|
||||
from app.services import gitea_client
|
||||
|
||||
# état mutable partagé : le PATCH est re-fetché par le handler via
|
||||
# get_issue, donc update doit modifier ce que get renverra.
|
||||
state = dict(_CANNED_ISSUE)
|
||||
|
||||
async def _create(owner, repo, title, body, **_k):
|
||||
state.update({"title": title, "body": body})
|
||||
return dict(state)
|
||||
|
||||
async def _update(owner, repo, issue_id, **kwargs):
|
||||
state.update(kwargs)
|
||||
return dict(state)
|
||||
|
||||
async def _labels(owner, repo, issue_id, label_ids):
|
||||
return [{"id": i} for i in label_ids]
|
||||
|
||||
async def _get(owner, repo, issue_id):
|
||||
return dict(state)
|
||||
|
||||
async def _comments(owner, repo, issue_id):
|
||||
return []
|
||||
|
||||
monkeypatch.setattr(gitea_client.gitea, "create_issue", _create)
|
||||
monkeypatch.setattr(gitea_client.gitea, "update_issue", _update)
|
||||
monkeypatch.setattr(gitea_client.gitea, "update_issue_labels", _labels)
|
||||
monkeypatch.setattr(gitea_client.gitea, "get_issue", _get)
|
||||
monkeypatch.setattr(gitea_client.gitea, "get_issue_comments", _comments)
|
||||
|
||||
|
||||
def test_api_gitea_issue_create_update_with_board(client, monkeypatch):
|
||||
"""POST create → carte sur le board ; PATCH update → colonne recalculée."""
|
||||
from app.db import get_conn
|
||||
|
||||
_stub_gitea(monkeypatch)
|
||||
_seed_board(client) # board (OWNER, REPO) via l'endpoint
|
||||
with get_conn() as conn:
|
||||
board_id = conn.execute(
|
||||
"SELECT id FROM boards WHERE project_owner=? AND project_name=?",
|
||||
(OWNER, REPO),
|
||||
).fetchone()["id"]
|
||||
conn.execute("DELETE FROM cards WHERE board_id=?", (board_id,))
|
||||
conn.commit()
|
||||
try:
|
||||
created = client.post(
|
||||
f"/api/issues/{OWNER}/{REPO}", params={"title": "Issue A32"}
|
||||
)
|
||||
assert created.status_code == 200, created.text
|
||||
assert created.json()["status"] == "ok"
|
||||
assert created.json()["issue"]["number"] == 42
|
||||
with get_conn() as conn:
|
||||
card = conn.execute(
|
||||
"SELECT column_name FROM cards WHERE board_id=? AND gitea_issue_id=42",
|
||||
(board_id,),
|
||||
).fetchone()
|
||||
assert card is not None # carte créée localement à partir de l'issue
|
||||
|
||||
patched = client.patch(
|
||||
f"/api/issues/{OWNER}/{REPO}/42", params={"title": "Renommé A32"}
|
||||
)
|
||||
assert patched.status_code == 200
|
||||
assert patched.json()["issue"]["title"] == "Renommé A32"
|
||||
with get_conn() as conn:
|
||||
card2 = conn.execute(
|
||||
"SELECT column_name FROM cards WHERE board_id=? AND gitea_issue_id=42",
|
||||
(board_id,),
|
||||
).fetchone()
|
||||
assert card2 is not None # colonne recalculée (UPDATE) sans perdre la carte
|
||||
finally:
|
||||
with get_conn() as conn:
|
||||
conn.execute("DELETE FROM cards WHERE board_id=?", (board_id,))
|
||||
conn.commit()
|
||||
|
||||
|
||||
def test_api_gitea_issue_detail_json_and_html(client, monkeypatch):
|
||||
"""GET détail (2 decorators, 1 handler) : JSON + rendu HTML."""
|
||||
_stub_gitea(monkeypatch)
|
||||
r = client.get(f"/api/issues/{OWNER}/{REPO}/42")
|
||||
assert r.status_code == 200
|
||||
d = r.json()
|
||||
assert d["issue"]["title"] == "Issue A32"
|
||||
assert d["comments"] == [] and d["checklists"] == [] and d["card"] is None
|
||||
|
||||
# le handler lit le paramètre `format` (le segment /html ne le fixe pas)
|
||||
html = client.get(f"/api/issues/{OWNER}/{REPO}/42/html", params={"format": "html"})
|
||||
assert html.status_code == 200
|
||||
assert "text/html" in html.headers["content-type"]
|
||||
assert "Issue A32" in html.text # card_detail.html rendu avec le canevas
|
||||
|
||||
# inconnu (le stub lève) → 404 propre
|
||||
from app.services import gitea_client
|
||||
|
||||
async def _boom(*_a, **_k):
|
||||
raise RuntimeError("pas trouvé")
|
||||
|
||||
monkeypatch.setattr(gitea_client.gitea, "get_issue", _boom)
|
||||
assert client.get(f"/api/issues/{OWNER}/{REPO}/999").status_code == 404
|
||||
|
||||
|
||||
def test_api_gitea_checklists_create_with_board(client):
|
||||
"""POST checklist + POST item : création vérifiée en base (DB seul)."""
|
||||
from app.db import get_conn
|
||||
|
||||
_seed_board(client)
|
||||
with get_conn() as conn:
|
||||
board_id = conn.execute(
|
||||
"SELECT id FROM boards WHERE project_owner=? AND project_name=?",
|
||||
(OWNER, REPO),
|
||||
).fetchone()["id"]
|
||||
cl_id = item_id = None
|
||||
try:
|
||||
r = client.post(
|
||||
f"/api/checklists/{OWNER}/{REPO}/42", params={"title": "À faire A32"}
|
||||
)
|
||||
assert r.status_code == 200 and r.json()["status"] == "ok"
|
||||
cl_id = r.json()["checklist_id"]
|
||||
with get_conn() as conn:
|
||||
row = conn.execute(
|
||||
"SELECT board_id, title FROM checklists WHERE id=?", (cl_id,)
|
||||
).fetchone()
|
||||
assert row["board_id"] == board_id and row["title"] == "À faire A32"
|
||||
|
||||
r2 = client.post(
|
||||
f"/api/checklist-items/{OWNER}/{REPO}/42/{cl_id}",
|
||||
params={"content": "étape 1"},
|
||||
)
|
||||
assert r2.status_code == 200 and r2.json()["status"] == "ok"
|
||||
item_id = r2.json()["item_id"]
|
||||
with get_conn() as conn:
|
||||
it = conn.execute(
|
||||
"SELECT content FROM checklist_items WHERE id=?", (item_id,)
|
||||
).fetchone()
|
||||
assert it["content"] == "étape 1"
|
||||
# board absent → 404 (validation côté route)
|
||||
assert client.post("/api/checklists/absent/repo/1").status_code == 404
|
||||
finally:
|
||||
with get_conn() as conn:
|
||||
if item_id is not None:
|
||||
conn.execute("DELETE FROM checklist_items WHERE id=?", (item_id,))
|
||||
if cl_id is not None:
|
||||
conn.execute("DELETE FROM checklists WHERE id=?", (cl_id,))
|
||||
conn.commit()
|
||||
|
||||
|
||||
def test_dashboard_gitea_workspace_page(client):
|
||||
r = client.get("/gitea-workspace")
|
||||
assert r.status_code in (200, 302), r.status_code
|
||||
|
||||
Reference in New Issue
Block a user