From 298617af586e30835998a32641882a8bbafc4bda Mon Sep 17 00:00:00 2001 From: bruno Date: Sat, 18 Jul 2026 09:44:48 -0400 Subject: [PATCH] revert: rollback _render_file_viewer wiring and URL encoding MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Rollback des commits 2226e5e et 2534e2b — les fichiers continuent de s'ouvrir dans page_editor.html (layout normal avec sidebar), pas dans le viewer standalone _render_file_viewer. --- app/routers/board.py | 10 ++-------- app/routers/dashboard.py | 8 +------- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/app/routers/board.py b/app/routers/board.py index e2784c2..e108bfd 100644 --- a/app/routers/board.py +++ b/app/routers/board.py @@ -926,10 +926,6 @@ async def view_page(request: Request, page_id: int): return HTMLResponse("

Page not found

", status_code=404) page = dict(row) - # For file-type pages (PDFs, images, etc.), use the dedicated file viewer - if page.get("content_format") == "file": - return _render_file_viewer(page, request) - ws = page.get("workspace", "") parts = ws.split("/") if "/" in ws else ["", ""] owner, repo = parts[0], parts[1] if len(parts) > 1 else "" @@ -963,8 +959,7 @@ async def view_page(request: Request, page_id: int): ws_id = p.replace("workspace_", "") break filename = fp_parts[-1] if fp_parts else page.get("title", "File") - from urllib.parse import quote - file_url = f"/api/files/{ws_id}/{quote(filename, safe='')}" if ws_id else "" + file_url = f"/api/files/{ws_id}/{filename}" if ws_id else "" page_data["file_url"] = file_url page_data["file_mime"] = mime_type page_data["file_size"] = file_size @@ -1011,8 +1006,7 @@ def _render_file_viewer(page: dict, request: Request) -> HTMLResponse: break filename = parts[-1] if parts else title - from urllib.parse import quote - file_url = f"/api/files/{ws_id}/{quote(filename, safe='')}" if ws_id else "" + file_url = f"/api/files/{ws_id}/{filename}" if ws_id else "" # Determine viewer type is_image = mime_type.startswith("image/") diff --git a/app/routers/dashboard.py b/app/routers/dashboard.py index 64ee8ca..f9517e1 100644 --- a/app/routers/dashboard.py +++ b/app/routers/dashboard.py @@ -235,11 +235,6 @@ async def view_page_root(request: Request, page_id: int): return HTMLResponse("

Page not found

", status_code=404) page = dict(row) - # For file-type pages (PDFs, images, etc.), use the dedicated file viewer - if page.get("content_format") == "file": - from app.routers.board import _render_file_viewer - return _render_file_viewer(page, request) - ws = page.get("workspace", "") parts = ws.split("/") if "/" in ws else ["", ""] owner, repo = parts[0], parts[1] if len(parts) > 1 else "" @@ -275,8 +270,7 @@ async def view_page_root(request: Request, page_id: int): ws_id = p.replace("workspace_", "") break filename = fp_parts[-1] if fp_parts else page.get("title", "File") - from urllib.parse import quote - file_url = f"/api/files/{ws_id}/{quote(filename, safe='')}" if ws_id else "" + file_url = f"/api/files/{ws_id}/{filename}" if ws_id else "" page_data["file_url"] = file_url page_data["file_mime"] = mime_type page_data["file_size"] = file_size