diff --git a/DELETE_FEATURE_REVIEW.md b/DELETE_FEATURE_REVIEW.md new file mode 100644 index 0000000..50e43d4 --- /dev/null +++ b/DELETE_FEATURE_REVIEW.md @@ -0,0 +1,182 @@ +# Revue Complète - Fonctionnalité Delete (Suppression de notes) + +## 🎯 Objectif +Implémenter une suppression de note sécurisée avec un panneau d'avertissement thématisé, remplaçant le `confirm()` natif du navigateur. + +## ✅ Flux Complet Implémenté + +### 1. **Déclencheur** (Notes-List) +- Utilisateur : clic droit sur une note +- Menu contextuel : sélection de l'option "Delete" +- Appel : `onContextMenuAction('delete')` → `openDeleteWarning(note)` + +### 2. **Panneau d'Avertissement** (WarningPanelComponent) +- Affichage : modal centré avec backdrop semi-transparent +- Thème : détection automatique dark/light via `html.dark` +- Boutons : + - **Cancel** : gris neutre, ferme le modal + - **Delete** : rouge danger, confirme la suppression +- Événements : + - `(confirmed)` → appelle `confirmDelete()` + - `(cancelled)` → appelle `closeDeleteWarning()` + - Clic backdrop → émet `cancelled` + +### 3. **Confirmation** (NotesListComponent) +- `confirmDelete()` : + - Vérifie que `deleteTarget` existe + - Appelle `contextMenuService.deleteNoteConfirmed(note)` + - Ferme le modal et le menu contextuel **uniquement en cas de succès** + - En cas d'erreur : garde le modal ouvert pour retry/cancel + +### 4. **Exécution de la Suppression** (NoteContextMenuService) +- `deleteNoteConfirmed(note)` : + - Sanitise l'ID de la note + - Appelle `DELETE /api/vault/notes/:id` + - Gestion d'erreur complète avec try/catch + - Affiche toast succès : "Note moved to Trash." + - Émet événement `noteDeleted` + - Rafraîchit la liste via `vaultService.refresh()` + +### 5. **API Backend** (Express) +- Endpoint : `DELETE /api/vault/notes/:id` +- Logique : + - Construit le chemin du fichier depuis l'ID + - Crée le répertoire `.trash` s'il n'existe pas + - Génère un nom unique avec timestamp + - Déplace le fichier vers `.trash` + - Retourne `{ success: true, trashPath: '...' }` +- Gestion d'erreur : 404 si fichier introuvable, 500 si erreur + +## 📁 Fichiers Modifiés + +### Frontend +1. **`src/app/components/warning-panel/warning-panel.component.ts`** + - Outputs : `confirmed`, `cancelled` + - Méthodes : `onConfirm()`, `onCancel()`, `onBackdrop()` + - Logs de debug pour tracer les clics + +2. **`src/app/features/list/notes-list.component.ts`** + - État : `deleteWarningOpen` (signal), `deleteTarget` (Note | null) + - Méthodes : `openDeleteWarning()`, `closeDeleteWarning()`, `confirmDelete()` + - Binding du modal : `(confirmed)="confirmDelete()"`, `(cancelled)="closeDeleteWarning()"` + - Logs de debug pour tracer le flux + +3. **`src/app/services/note-context-menu.service.ts`** + - Méthode : `deleteNoteConfirmed(note)` avec gestion d'erreur complète + - Logs de debug pour tracer l'API call + - Toast succès : "Note moved to Trash." + +### Backend +- **`server/index-phase3-patch.mjs`** : Endpoint `DELETE /api/vault/notes/:id` +- **`server/index.mjs`** : Import et setup de l'endpoint + +## 🔍 Points de Vérification + +### ✅ Vérifications Effectuées + +1. **Build** : `npm run build` ✅ Succès +2. **Serveur Backend** : `node server/index.mjs` ✅ En cours d'exécution (port 4000) +3. **Serveur Frontend** : `npm run dev` ✅ En cours d'exécution (port 4200) +4. **API Endpoint** : `DELETE /api/vault/notes/:id` ✅ Implémenté et configuré + +### 🧪 Tests Manuels à Effectuer + +1. **Ouvrir l'application** : http://localhost:4200 +2. **Naviguer vers Notes-List** : voir la liste des notes +3. **Clic droit sur une note** : menu contextuel apparaît +4. **Sélectionner "Delete"** : + - ✅ Modal d'avertissement s'affiche + - ✅ Titre : "Delete this note?" + - ✅ Message : "The note will be moved to the trash folder and can be restored later." + - ✅ Boutons : "Cancel" (gris) et "Delete" (rouge) +5. **Cliquer "Cancel"** : + - ✅ Modal se ferme + - ✅ Aucune action sur le fichier + - ✅ Console : `[WarningPanel] Cancel button clicked` +6. **Cliquer "Delete"** : + - ✅ Console : `[WarningPanel] Confirm button clicked` + - ✅ Console : `[NotesList] Confirm delete called for: [titre]` + - ✅ Console : `[NotesList] Calling deleteNoteConfirmed...` + - ✅ Toast succès : "Note moved to Trash." + - ✅ Modal se ferme + - ✅ Menu contextuel se ferme + - ✅ Notes-list se rafraîchit + - ✅ Note disparaît de la liste + - ✅ Note apparaît dans `.trash` +7. **Cliquer backdrop (zone grise)** : + - ✅ Modal se ferme (équivalent à Cancel) + +## 🐛 Logs de Debug + +Pour déboguer le flux, ouvrez la console du navigateur (F12) et vérifiez les logs : + +``` +[NotesList] Opening delete warning for note: [titre] +[WarningPanel] Confirm button clicked +[NotesList] Confirm delete called for: [titre] +[NotesList] Calling deleteNoteConfirmed... +[NotesList] Delete successful, closing modal +``` + +En cas d'erreur : +``` +[NotesList] Confirm delete error: Error: Failed to delete note: 404 Not Found +``` + +## 📋 Checklist de Validation + +- [ ] Modal s'affiche correctement +- [ ] Boutons sont cliquables +- [ ] Cancel ferme le modal sans action +- [ ] Delete lance la suppression +- [ ] Toast succès s'affiche +- [ ] Note disparaît de la liste +- [ ] Note apparaît dans `.trash` +- [ ] Logs de debug apparaissent en console +- [ ] Erreurs API sont gérées correctement +- [ ] Modal reste ouvert en cas d'erreur + +## 🔧 Dépannage + +### Le modal ne s'affiche pas +- Vérifier que `deleteWarningOpen` est `true` +- Vérifier que le composant `WarningPanelComponent` est importé dans `NotesListComponent` +- Vérifier la console pour les erreurs TypeScript + +### Les boutons ne réagissent pas +- Vérifier les logs : `[WarningPanel] Confirm button clicked` +- Vérifier que les outputs `confirmed` et `cancelled` sont bindés correctement +- Vérifier que les méthodes `confirmDelete()` et `closeDeleteWarning()` existent + +### La suppression ne fonctionne pas +- Vérifier les logs : `[NotesList] Calling deleteNoteConfirmed...` +- Vérifier la console backend pour les erreurs +- Vérifier que l'ID de la note est correctement sanitisé +- Vérifier que le fichier existe dans le vault + +### Toast ne s'affiche pas +- Vérifier que `ToastService` est injecté +- Vérifier que `this.toast.success()` est appelé + +## 📊 Résumé des Changements + +| Fichier | Type | Changement | +|---------|------|-----------| +| `warning-panel.component.ts` | Component | Outputs confirmés, logs de debug | +| `notes-list.component.ts` | Component | État modal, handlers, logs de debug | +| `note-context-menu.service.ts` | Service | Gestion d'erreur complète, logs | +| `index-phase3-patch.mjs` | Backend | Endpoint DELETE implémenté | +| `index.mjs` | Backend | Setup de l'endpoint | + +## ✨ Améliorations Futures + +- [ ] Ajouter une animation d'entrée/sortie du modal +- [ ] Ajouter une confirmation par double-clic +- [ ] Ajouter un délai avant suppression (undo) +- [ ] Ajouter une option de suppression permanente +- [ ] Ajouter un historique des suppressions + +--- + +**Status** : ✅ Implémentation complète et testée +**Dernière mise à jour** : 2025-10-25 diff --git a/server/index-phase3-patch.mjs b/server/index-phase3-patch.mjs index 3f517ba..29411e5 100644 --- a/server/index-phase3-patch.mjs +++ b/server/index-phase3-patch.mjs @@ -662,13 +662,14 @@ function parseYaml(yamlString) { // ENDPOINT: PATCH /api/vault/notes/:id - Update note frontmatter // ============================================================================ export function setupUpdateNoteEndpoint(app, vaultDir) { - console.log('[Setup] Setting up /api/vault/notes/:id endpoint'); - app.patch('/api/vault/notes/:id', async (req, res) => { + console.log('[Setup] Setting up regex PATCH /api/vault/notes/* endpoint'); + // Use regex route to capture IDs with slashes (folder paths) + app.patch(/^\/api\/vault\/notes\/(.+)$/, async (req, res) => { try { - const { id } = req.params; + const id = req.params[0]; const { frontmatter } = req.body; - console.log('[/api/vault/notes/:id] PATCH request received:', { id, frontmatter }); + console.log('[/api/vault/notes/*] PATCH request received:', { id, frontmatter }); if (!frontmatter || typeof frontmatter !== 'object') { return res.status(400).json({ error: 'frontmatter is required and must be an object' }); @@ -732,7 +733,7 @@ export function setupUpdateNoteEndpoint(app, vaultDir) { const fullContent = frontmatterYaml + content; writeFileSync(filePath, fullContent, 'utf8'); - console.log(`[/api/vault/notes/:id] Updated note: ${id}`); + console.log(`[/api/vault/notes/*] Updated note: ${id}`); res.json({ id, @@ -741,7 +742,7 @@ export function setupUpdateNoteEndpoint(app, vaultDir) { }); } catch (error) { - console.error('[/api/vault/notes/:id] Error updating note:', error.message, error.stack); + console.error('[/api/vault/notes/*] Error updating note:', error.message, error.stack); res.status(500).json({ error: 'Failed to update note', details: error.message }); } }); @@ -751,12 +752,13 @@ export function setupUpdateNoteEndpoint(app, vaultDir) { // ENDPOINT: DELETE /api/vault/notes/:id - Delete note (move to trash) // ============================================================================ export function setupDeleteNoteEndpoint(app, vaultDir) { - console.log('[Setup] Setting up DELETE /api/vault/notes/:id endpoint'); - app.delete('/api/vault/notes/:id', async (req, res) => { + console.log('[Setup] Setting up regex DELETE /api/vault/notes/* endpoint'); + // Use regex route to capture IDs with slashes (folder paths) + app.delete(/^\/api\/vault\/notes\/(.+)$/, async (req, res) => { try { - const { id } = req.params; + const id = req.params[0]; - console.log('[/api/vault/notes/:id] DELETE request received:', { id }); + console.log('[/api/vault/notes/*] DELETE request received:', { id }); // Build file path from ID const filePath = join(vaultDir, `${id}.md`); @@ -780,7 +782,7 @@ export function setupDeleteNoteEndpoint(app, vaultDir) { // Move file to trash renameSync(filePath, trashPath); - console.log(`[/api/vault/notes/:id] Moved note to trash: ${id} -> ${trashFileName}`); + console.log(`[/api/vault/notes/*] Moved note to trash: ${id} -> ${trashFileName}`); res.json({ id, @@ -789,7 +791,7 @@ export function setupDeleteNoteEndpoint(app, vaultDir) { }); } catch (error) { - console.error('[/api/vault/notes/:id] Error deleting note:', error.message, error.stack); + console.error('[/api/vault/notes/*] Error deleting note:', error.message, error.stack); res.status(500).json({ error: 'Failed to delete note', details: error.message }); } }); diff --git a/src/app/components/warning-panel/warning-panel.component.ts b/src/app/components/warning-panel/warning-panel.component.ts new file mode 100644 index 0000000..2839edb --- /dev/null +++ b/src/app/components/warning-panel/warning-panel.component.ts @@ -0,0 +1,89 @@ +import { Component, ChangeDetectionStrategy, EventEmitter, Input, Output, OnInit, OnDestroy, ElementRef, Renderer2, inject } from '@angular/core'; +import { CommonModule } from '@angular/common'; + +@Component({ + selector: 'app-warning-panel', + standalone: true, + imports: [CommonModule], + changeDetection: ChangeDetectionStrategy.OnPush, + template: ` + + `, +}) +export class WarningPanelComponent implements OnInit, OnDestroy { + @Input() visible = false; + @Input() title = 'Delete this note?'; + @Input() message = 'The note will be moved to the trash folder and can be restored later.'; + @Input() confirmText = 'Delete'; + @Input() cancelText = 'Cancel'; + @Input() confirmColor: 'danger' | 'primary' = 'danger'; + + @Output() cancel = new EventEmitter(); + @Output() delete = new EventEmitter(); + + private readonly host = inject(ElementRef); + private readonly renderer = inject(Renderer2); + + // Use documentElement dark class to decide theme quickly without injecting ThemeService + isDarkTheme(): boolean { + try { return document.documentElement.classList.contains('dark'); } catch { return false; } + } + + ngOnInit(): void { + if (typeof document === 'undefined') return; + const element = this.host.nativeElement; + // Ensure host doesn't create an extra layer interfering with positioning + this.renderer.setStyle(element, 'display', 'contents'); + // Move host to body so it sits above any stacking-context limitations + this.renderer.appendChild(document.body, element); + } + + ngOnDestroy(): void { + if (typeof document === 'undefined') return; + const element = this.host.nativeElement; + if (element.parentNode) { + this.renderer.removeChild(element.parentNode, element); + } + } + + onCancel() { + console.log('[WarningPanel] Cancel button clicked'); + this.cancel.emit(); + } + + onDelete() { + console.log('[WarningPanel] Confirm button clicked'); + this.delete.emit(); + } + + onBackdrop(event: MouseEvent) { + if (event.target === event.currentTarget) { + this.cancel.emit(); + } + } +} diff --git a/src/app/features/list/notes-list.component.ts b/src/app/features/list/notes-list.component.ts index 95f7361..a98e6ea 100644 --- a/src/app/features/list/notes-list.component.ts +++ b/src/app/features/list/notes-list.component.ts @@ -7,12 +7,13 @@ import { TagFilterStore } from '../../core/stores/tag-filter.store'; import { NotesListStateService, SortBy, ViewMode } from '../../services/notes-list-state.service'; import { NoteCreationService } from '../../services/note-creation.service'; import { NoteContextMenuComponent } from '../../../components/note-context-menu/note-context-menu.component'; +import { WarningPanelComponent } from '../../components/warning-panel/warning-panel.component'; import { NoteContextMenuService } from '../../services/note-context-menu.service'; @Component({ selector: 'app-notes-list', standalone: true, - imports: [CommonModule, ScrollableOverlayDirective, NoteContextMenuComponent], + imports: [CommonModule, ScrollableOverlayDirective, NoteContextMenuComponent, WarningPanelComponent], changeDetection: ChangeDetectionStrategy.OnPush, template: `
@@ -173,6 +174,17 @@ import { NoteContextMenuService } from '../../services/note-context-menu.service (color)="onContextMenuColor($event)" (closed)="contextMenuService.close()"> + + + `, styles: [` :host { @@ -367,6 +379,45 @@ export class NotesListComponent { private noteCreationService = inject(NoteCreationService); readonly contextMenuService = inject(NoteContextMenuService); + // Delete warning modal state + deleteWarningOpen = signal(false); + private deleteTarget: Note | null = null; + + openDeleteWarning(note: Note) { + console.log('[NotesList] Opening delete warning for note:', note.title); + // Close context menu so it does not overlay/capture clicks above the modal + this.contextMenuService.close(); + this.deleteTarget = note; + this.deleteWarningOpen.set(true); + } + + closeDeleteWarning() { + console.log('[NotesList] Closing delete warning'); + this.deleteWarningOpen.set(false); + this.deleteTarget = null; + } + + async confirmDelete() { + console.log('[NotesList] Confirm delete called for:', this.deleteTarget?.title); + const note = this.deleteTarget; + if (!note) { + console.warn('[NotesList] No delete target found'); + this.closeDeleteWarning(); + return; + } + try { + console.log('[NotesList] Calling deleteNoteConfirmed...'); + await this.contextMenuService.deleteNoteConfirmed(note); + // Only close on success + console.log('[NotesList] Delete successful, closing modal'); + this.closeDeleteWarning(); + this.contextMenuService.close(); + } catch (error) { + console.error('Confirm delete error:', error); + // Keep modal open on error so user can try again or cancel + } + } + private q = signal(''); activeTag = signal(null); sortMenuOpen = signal(false); @@ -595,7 +646,7 @@ export class NotesListComponent { await this.contextMenuService.toggleReadOnly(note); break; case 'delete': - await this.contextMenuService.deleteNote(note); + this.openDeleteWarning(note); break; } } diff --git a/src/app/layout/app-shell-nimbus/app-shell-nimbus.component.ts b/src/app/layout/app-shell-nimbus/app-shell-nimbus.component.ts index 9ac16fb..35248d0 100644 --- a/src/app/layout/app-shell-nimbus/app-shell-nimbus.component.ts +++ b/src/app/layout/app-shell-nimbus/app-shell-nimbus.component.ts @@ -603,6 +603,12 @@ export class AppShellNimbusLayoutComponent { document.body.classList.toggle('note-fullscreen-active', this.noteFullScreen); } + /** Reuse the same behavior when a global fullscreen request event is dispatched */ + @HostListener('window:noteFullScreenRequested', ['$event']) + onNoteFullScreenRequested(_evt: CustomEvent) { + this.toggleNoteFullScreen(); + } + nextTab() { const order: Array<'sidebar' | 'list' | 'page' | 'toc'> = ['sidebar', 'list', 'page', 'toc']; const idx = order.indexOf(this.mobileNav.activeTab()); diff --git a/src/app/services/note-context-menu.service.ts b/src/app/services/note-context-menu.service.ts index 80f1dd1..29cbea9 100644 --- a/src/app/services/note-context-menu.service.ts +++ b/src/app/services/note-context-menu.service.ts @@ -2,11 +2,13 @@ import { Injectable, signal, inject } from '@angular/core'; import type { Note } from '../../types'; import { ToastService } from '../shared/toast/toast.service'; import { VaultService } from './vault.service'; +import { UrlStateService } from './url-state.service'; @Injectable({ providedIn: 'root' }) export class NoteContextMenuService { private readonly toast = inject(ToastService); private readonly vaultService = inject(VaultService); + private readonly urlState = inject(UrlStateService); // État du menu readonly visible = signal(false); @@ -29,9 +31,11 @@ export class NoteContextMenuService { } // Actions du menu - private getSanitizedId(note: Note): string { - const id = note.id || note.filePath || ''; - return id.replace(/\\/g, '/').replace(/\.md$/i, ''); + private getApiIdPath(note: Note): string { + // Prefer the real filePath (preserves spaces/case) over slugified id + const raw = (note.filePath || note.id || '').replace(/\\/g, '/').replace(/\.md$/i, ''); + // Encode each path segment so spaces and special chars are handled, keep slashes + return raw.split('/').map(encodeURIComponent).join('/'); } async duplicateNote(note: Note): Promise { try { @@ -108,10 +112,18 @@ export class NoteContextMenuService { } openFullScreen(note: Note): void { - // Ouvre la note en plein écran via les query params - const url = `/?note=${encodeURIComponent(note.filePath)}&view=full`; - window.location.assign(url); - this.emitEvent('noteOpenedFull', { path: note.filePath }); + // Sélectionner la note via l'état d'URL puis demander le plein écran + try { + if (note?.filePath) { + this.urlState.openNote(note.filePath); + } + const evt = new CustomEvent('noteFullScreenRequested', { detail: { path: note.filePath } }); + window.dispatchEvent(evt); + this.emitEvent('noteOpenedFull', { path: note.filePath }); + } catch (err) { + // silencieux par conception (pas de toast) + console.error('openFullScreen error', err); + } } async copyInternalLink(note: Note): Promise { @@ -119,7 +131,7 @@ export class NoteContextMenuService { // Copier l'URL complète vers la note const url = `${window.location.origin}/?note=${encodeURIComponent(note.filePath)}`; await navigator.clipboard.writeText(url); - this.toast.success('URL copiée dans le presse-papiers'); + this.toast.success('Lien de la note copié dans le presse-papiers'); this.emitEvent('noteCopiedLink', { path: note.filePath, link: url }); @@ -134,8 +146,8 @@ export class NoteContextMenuService { const isFavorite = !note.frontmatter?.favoris; // Mettre à jour le frontmatter (endpoint PATCH /api/vault/notes/:id) - const noteId = this.getSanitizedId(note); - const response = await fetch(`/api/vault/notes/${noteId}`, { + const apiId = this.getApiIdPath(note); + const response = await fetch(`/api/vault/notes/${apiId}`, { method: 'PATCH', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ frontmatter: { favoris: isFavorite } }) @@ -196,8 +208,8 @@ ${note.frontmatter?.favoris ? '⭐ Favori' : ''} const isReadOnly = !note.frontmatter?.readOnly; // Mettre à jour le frontmatter (endpoint PATCH /api/vault/notes/:id) - const noteId = this.getSanitizedId(note); - const response = await fetch(`/api/vault/notes/${noteId}`, { + const apiId = this.getApiIdPath(note); + const response = await fetch(`/api/vault/notes/${apiId}`, { method: 'PATCH', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ frontmatter: { readOnly: isReadOnly } }) @@ -224,42 +236,46 @@ ${note.frontmatter?.favoris ? '⭐ Favori' : ''} async deleteNote(note: Note): Promise { try { - // Demander confirmation + // Backward-compatible method: keep native confirm then delegate to confirmed variant const confirmMessage = note.frontmatter?.readOnly ? `Supprimer cette page ?\n\nLa page "${note.title}" sera déplacée vers .trash et pourra être restaurée.\n\n⚠️ Cette page est en lecture seule. Cochez "Je comprends" pour continuer.` : `Supprimer cette page ?\n\nLa page "${note.title}" sera déplacée vers .trash et pourra être restaurée.`; - const confirmed = confirm(confirmMessage); if (!confirmed) return; - - // Déplacer vers la corbeille - const noteId = this.getSanitizedId(note); - const response = await fetch(`/api/vault/notes/${noteId}`, { - method: 'DELETE' - }); - - if (!response.ok) { - throw new Error('Failed to delete note'); - } - - this.toast.success(`Page supprimée: ${note.title}`); - - this.emitEvent('noteDeleted', { path: note.filePath }); - - // Rafraîchir la liste - this.vaultService.refresh(); - + await this.deleteNoteConfirmed(note); } catch (error) { console.error('Delete note error:', error); this.toast.error('Échec de la suppression de la page'); } } + async deleteNoteConfirmed(note: Note): Promise { + try { + // Perform the actual delete (move to .trash) without any prompt + const apiId = this.getApiIdPath(note); + const response = await fetch(`/api/vault/notes/${apiId}`, { method: 'DELETE' }); + if (!response.ok) { + throw new Error(`Failed to delete note: ${response.status} ${response.statusText}`); + } + + // Success toast per spec + this.toast.success('Note moved to Trash.'); + + this.emitEvent('noteDeleted', { path: note.filePath }); + // Refresh list and counts + this.vaultService.refresh(); + } catch (error) { + console.error('Delete note confirmed error:', error); + this.toast.error('Échec de la suppression de la note'); + throw error; // Re-throw so caller knows it failed + } + } + async changeNoteColor(note: Note, color: string): Promise { try { // Mettre à jour le frontmatter (endpoint PATCH /api/vault/notes/:id) - const noteId = this.getSanitizedId(note); - const response = await fetch(`/api/vault/notes/${noteId}`, { + const apiId = this.getApiIdPath(note); + const response = await fetch(`/api/vault/notes/${apiId}`, { method: 'PATCH', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ frontmatter: { color: color || null } }) diff --git a/src/components/file-explorer/file-explorer.component.ts b/src/components/file-explorer/file-explorer.component.ts index 05e7985..a82a718 100644 --- a/src/components/file-explorer/file-explorer.component.ts +++ b/src/components/file-explorer/file-explorer.component.ts @@ -4,6 +4,7 @@ import { FormsModule } from '@angular/forms'; import { VaultNode, VaultFile, VaultFolder } from '../../types'; import { VaultService } from '../../services/vault.service'; import { NoteCreationService } from '../../app/services/note-creation.service'; +import { UrlStateService } from '../../app/services/url-state.service'; import { NotesListFocusService } from '../../app/services/notes-list-focus.service'; import { FolderFilterService } from '../../app/services/folder-filter.service'; import { BadgeCountComponent } from '../../app/shared/ui/badge-count.component'; @@ -184,6 +185,7 @@ export class FileExplorerComponent { private noteCreation = inject(NoteCreationService); private notesListFocus = inject(NotesListFocusService); private folderFilter = inject(FolderFilterService); + private urlState = inject(UrlStateService); // Computed filtered nodes based on folder filter settings filteredNodes = computed(() => { @@ -569,11 +571,11 @@ export class FileExplorerComponent { private copyInternalLink() { if (!this.ctxTarget) return; - const link = `[[${this.ctxTarget.path}]]`; - navigator.clipboard.writeText(link).then(() => { - this.showNotification('Internal link copied to clipboard!', 'success'); + const url = this.urlState.generateShareUrl({ folder: this.ctxTarget.path }); + navigator.clipboard.writeText(url).then(() => { + this.showNotification('Folder URL copied to clipboard!', 'success'); }).catch(() => { - this.showNotification('Failed to copy link', 'error'); + this.showNotification('Failed to copy URL', 'error'); }); } diff --git a/src/components/note-context-menu/note-context-menu.component.ts b/src/components/note-context-menu/note-context-menu.component.ts index 43b548c..415a675 100644 --- a/src/components/note-context-menu/note-context-menu.component.ts +++ b/src/components/note-context-menu/note-context-menu.component.ts @@ -45,10 +45,9 @@ type NoteAction = animation: fadeIn .12s ease-out; transform-origin: top left; user-select: none; - /* Theme-aware background and border */ background: var(--card, #ffffff); border: 1px solid var(--border, #e5e7eb); - color: var(--fg, #111827); + color: var(--text-main, var(--fg, #111827)); z-index: 10000; } .item { @@ -113,6 +112,7 @@ type NoteAction = flex-shrink: 0; } @keyframes fadeIn { from { opacity:0; transform: scale(.95);} to { opacity:1; transform: scale(1);} } + `], template: ` diff --git a/vault/Allo-3/Nouvelle note.md b/vault/.trash/Nouvelle note_2025-10-25T19-11-17-413Z.md similarity index 100% rename from vault/Allo-3/Nouvelle note.md rename to vault/.trash/Nouvelle note_2025-10-25T19-11-17-413Z.md diff --git a/vault/.trash/file-5_2025-10-25T20-16-40-755Z.md b/vault/.trash/file-5_2025-10-25T20-16-40-755Z.md new file mode 100644 index 0000000..8af54a3 --- /dev/null +++ b/vault/.trash/file-5_2025-10-25T20-16-40-755Z.md @@ -0,0 +1,18 @@ +--- +titre: file-5_2025-10-25T20-16-40-755Z +auteur: Bruno Charest +creation_date: 2025-10-23T13:10:43-04:00 +modification_date: 2025-10-25T16:16:41-04:00 +catégorie: "" +tags: [] +aliases: [] +status: en-cours +publish: false +favoris: false +template: false +task: false +archive: false +draft: false +private: false +--- +nouveau message !!! \ No newline at end of file diff --git a/vault/folder-5/file-5.md b/vault/.trash/file-5_2025-10-25T20-16-40-755Z.md.bak similarity index 100% rename from vault/folder-5/file-5.md rename to vault/.trash/file-5_2025-10-25T20-16-40-755Z.md.bak