feat: assistant IA — approbation groupee des actions, bloc d'etapes, refresh UI et bouton Stop (BUG-074, BUG-075, BUG-076, BUG-077)

tests/frontend/ai.test.mjs

@@ -104,6 +104,7 @@ async function main() {
   const bookslmMod = await import(pathToFileURL(path.join(JS_DIR, "bookslm.js")).href);
   const { BooksLM, MODE } = bookslmMod;
   const { collectOpenDocuments, documentsSignature } = bookslmMod;
+  const { t } = await import(pathToFileURL(path.join(JS_DIR, "i18n.js")).href);
   const { state } = await import(pathToFileURL(path.join(JS_DIR, "state.js")).href);
 
   // ── 1. Rewrite modal resolves with the typed instruction ──
@@ -213,8 +214,14 @@ async function main() {
     const { readFileSync } = await import("node:fs");
     const src = readFileSync(path.join(JS_DIR, "bookslm.js"), "utf-8");
     const apply = src.slice(src.indexOf("async _applyConfirmation"));
-    assert.match(apply, /payload:\s*msg\.payload\s*\?\s*\{[^\n]*\.\.\.msg\.payload[^\n]*\}\s*:\s*null/,
-      "continuation must inherit the original request payload (no null payload)");
+    // BUG-075: the whole batch is approved at once and the continuation keeps
+    // streaming into the SAME message (its `payload` stays available, so the
+    // BUG-046 null-payload regression cannot reappear).
+    assert.match(apply, /confirm_all:\s*true/, "global approval flag sent");
+    assert.match(apply, /await this\._streamResponse\(resp, msg, payload\)/,
+      "resume streams into the original message (payload preserved)");
+    assert.doesNotMatch(apply, /this\._messages\.push\(continuation\)/,
+      "no fragmented continuation message per approval");
     assert.match(apply, /await this\._responseError\(resp\)/,
       "resume path must format non-OK responses via _responseError");
   });
@@ -550,6 +557,50 @@ async function main() {
       assert.ok(summary.getAttribute("aria-label"), "the state is announced to screen readers");
     });
 
+    await test("the steps header previews the first action and counts actions only (BUG-074)", () => {
+      const b = new BooksLM();
+      // Two reasoning notes + one action → the header counts 1 action and
+      // previews it; the notes must not inflate the counter.
+      const calls = [
+        { name: "", ok: true, step: { key: "thought", params: { value: "je réfléchis" } } },
+        { name: "create_file", ok: true, step: { key: "file_create", params: { value: "a.md" } } },
+        { name: "", ok: true, step: { key: "thought", params: { value: "encore" } } },
+      ];
+      const trace = b._renderToolActivity(calls, {}, false);
+      const summary = trace.querySelector("summary");
+      assert.equal(
+        summary.querySelector(".bookslm-steps-label").textContent,
+        t("ai.steps_count", { count: 1 }),
+        "only actions are counted",
+      );
+      const title = summary.querySelector(".bookslm-steps-title");
+      assert.ok(title, "the first action is previewed in the collapsed header");
+      assert.ok(title.textContent.startsWith("— "), "preview is prefixed with a dash");
+      assert.ok(title.textContent.includes(b._stepText(calls[1])),
+        "preview shows the first action's label");
+      // Several actions → plural label.
+      const two = b._renderToolActivity([
+        { name: "create_file", ok: true, step: { key: "file_create", params: { value: "a.md" } } },
+        { name: "create_directory", ok: true, step: { key: "dir_create", params: { value: "d" } } },
+      ], {}, false);
+      assert.equal(
+        two.querySelector(".bookslm-steps-label").textContent,
+        t("ai.steps_count_plural", { count: 2 }),
+        "plural for several actions",
+      );
+    });
+
+    await test("_actionStepCount ignores reasoning notes (BUG-074)", () => {
+      const b = new BooksLM();
+      assert.equal(b._actionStepCount([
+        { step: { key: "thought" } },
+        { step: { key: "file_create" } },
+      ]), 1, "only the action is counted");
+      assert.equal(b._actionStepCount([{ step: { key: "thought" } }]), 1,
+        "a thoughts-only block still shows 1, never 0");
+      assert.equal(b._actionStepCount([]), 0);
+    });
+
     await test("reasoning notes become « Réflexion » sub-sections, open state kept", () => {
       const b = new BooksLM();
       const msg = {};
@@ -1206,14 +1257,119 @@ async function main() {
     assert.equal(msg.confirmation, null, "confirmation resolved");
     assert.ok(posted, "resumed via /agent");
     assert.equal(posted.confirm.error.tool, "edit_file");
+    assert.equal(posted.confirm_all, true, "BUG-075: global approval flag sent");
     assert.deepEqual(posted.confirm_messages, [{ role: "system", content: "s" }]);
+    // BUG-074: the continuation stays in the same message (cumulative steps).
+    assert.equal(b._messages.length, 1, "no fragmented continuation message");
     const cont = b._messages[b._messages.length - 1];
+    assert.equal(cont, msg, "streams into the original message");
     assert.equal(cont.content, "Fait.");
     assert.equal(cont.toolCalls.length, 1, "tool trace captured");
     b._panel.remove();
     localStorage.clear();
   });
 
+  await test("a batch confirmation lists every action and offers one approval (BUG-075)", () => {
+    const b = new BooksLM();
+    b._panel = b._render();
+    document.body.appendChild(b._panel);
+    b._fillConfirmationDiff = async () => {};
+    const msg = {
+      role: "assistant",
+      content: "",
+      confirmation: {
+        pending: {
+          error: { tool: "create_file", arguments: { vault: "V", path: "a.md" }, id: "1" },
+          actions: [
+            { id: "1", tool: "create_directory", step: { key: "dir_create", params: { value: "proj" } }, arguments: { vault: "V", path: "proj" } },
+            { id: "2", tool: "create_file", step: { key: "file_create", params: { value: "proj/a.md" } }, arguments: { vault: "V", path: "proj/a.md", content: "x" } },
+          ],
+        },
+        messages: [],
+      },
+    };
+    const card = b._renderConfirmationCard(msg);
+    const rows = card.querySelectorAll(".bookslm-confirm-action");
+    assert.equal(rows.length, 2, "one row per pending action");
+    assert.ok(
+      rows[0].querySelector("summary").textContent.includes(
+        b._stepText({ step: { key: "dir_create", params: { value: "proj" } }, name: "create_directory" }),
+      ),
+      "each row shows the action's human label",
+    );
+    const apply = card.querySelector(".bookslm-action-apply");
+    assert.equal(apply.textContent, t("ai.action_apply_all", { count: 2 }),
+      "a single global approval button");
+    b._panel.remove();
+  });
+
+  await test("single-action confirmation keeps the legacy Apply label (BUG-075)", () => {
+    const b = new BooksLM();
+    b._panel = b._render();
+    document.body.appendChild(b._panel);
+    b._fillConfirmationDiff = async () => {};
+    const msg = {
+      role: "assistant",
+      content: "",
+      confirmation: {
+        pending: { error: { tool: "edit_file", arguments: { vault: "V", path: "a.md", content: "x" }, id: "1" } },
+        messages: [],
+      },
+    };
+    const card = b._renderConfirmationCard(msg);
+    assert.equal(card.querySelectorAll(".bookslm-confirm-action").length, 0,
+      "no batch list for a single action");
+    assert.equal(card.querySelector(".bookslm-action-apply").textContent, t("ai.action_apply"));
+    b._panel.remove();
+  });
+
+  await test("the send button doubles as a Stop control while running (BUG-077)", () => {
+    const b = new BooksLM();
+    b._panel = b._render();
+    document.body.appendChild(b._panel);
+    const btn = b._panel.querySelector(".bookslm-btn-send");
+    b._syncSendButton();
+    assert.equal(btn.querySelector("i").getAttribute("data-lucide"), "arrow-up");
+    assert.ok(!btn.classList.contains("is-stopping"), "idle: normal send button");
+
+    let aborted = false;
+    b._isLoading = true;
+    b._abortCtrl = { abort: () => { aborted = true; } };
+    b._syncSendButton();
+    assert.ok(btn.classList.contains("is-stopping"), "stop state applied while running");
+    assert.equal(btn.querySelector("i").getAttribute("data-lucide"), "square");
+    btn.click();
+    assert.ok(aborted, "clicking while running aborts the request");
+    b._isLoading = false;
+    b._panel.remove();
+  });
+
+  await test("_markStopped appends a visible stop marker (BUG-077)", () => {
+    const b = new BooksLM();
+    const msg = { content: "Début de réponse" };
+    b._markStopped(msg);
+    assert.ok(msg.content.includes("⏹"), "marker present");
+    assert.ok(msg.content.startsWith("Début de réponse"), "partial answer kept");
+    assert.ok(!msg.content.includes("⏹\n"), "marker separated from the answer");
+    const empty = { content: "" };
+    b._markStopped(empty);
+    assert.ok(empty.content.includes("⏹"));
+    assert.ok(!empty.content.startsWith("\n"), "no leading blank line for an empty answer");
+  });
+
+  await test("document writes notify the viewer; path-less tools do not (BUG-076)", () => {
+    const b = new BooksLM();
+    const seen = [];
+    const handler = (e) => seen.push(e.detail);
+    window.addEventListener("obsigate:file-written", handler);
+    b._notifyFileWritten({ name: "create_xlsx", ok: true, arguments: { vault: "V", path: "a.xlsx" } });
+    b._notifyFileWritten({ name: "edit_file", ok: false, arguments: { vault: "V", path: "b.md" } });
+    b._notifyFileWritten({ name: "replace_in_files", ok: true, arguments: { vault: "V" } });
+    window.removeEventListener("obsigate:file-written", handler);
+    assert.equal(seen.length, 1, "only the successful path-bearing write notifies");
+    assert.equal(seen[0].path, "a.xlsx");
+  });
+
   // ── 29. Resizable panel bounds and persistence (#81) ──
   await test("panel width is clamped and persisted", async () => {
     localStorage.clear();